Improvements on browser SSO - #3907
Merged
madurangasiriwardena merged 1 commit intoJul 10, 2026
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Follow-up to #3779 (flow-centric browser SSO), addressing review comments raised after merge. Pure code-organization and internal-cleanup changes in the flow session subsystem — no behavioral or API changes.
Approach
storetype behind a single package-privatesessionStoreinterface, their split source files (session_context_store.go,participant_store.go) are merged intostore.go. All methods already had the*storereceiver, so this is a pure file consolidation.SSO-SESS-NNprefix (01–11), dropping the old-AC-/-PART-sub-prefixes that reflected the previously-separate stores. IDs are internal identifiers only (no DB/functional impact).TestSSOFlowDefinitionBuildsnow constructs the flow definition inline as a Go literal (matching the dominant pattern ingraph_builder_test.go), andtestdata/sso_flow.jsonis removed. The test still runs against the real executor registry, so a typo'd executor name or dangling node reference still fails it.initContext/loadContextFromStore) instead of re-fetching it in a dedicatedresolveActiveFlowVersioncall. That method and the now-redundantflowUsesSSOSessiongate are removed; the version is carried onEngineContext.SSOFlowVersionthe same way the inbound handle already is.Related Issues
Related PRs
Checklist
breaking changelabel added.Security checks
Summary by CodeRabbit
Bug Fixes
New Features